Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Finance (Sistema Financeiro Aberto) participants #234

Open
guibranco opened this issue Jun 26, 2023 · 0 comments
Open

Add Open Finance (Sistema Financeiro Aberto) participants #234

guibranco opened this issue Jun 26, 2023 · 0 comments
Labels
dependencies Pull requests that update a dependency file documentation enhancement A enhancement to the project good first issue A issue for someone self assign and help me =D help wanted Feel free to take this issue for you and help me! .NET Pull requests that update .net code new source schema

Comments

@guibranco
Copy link
Owner

guibranco commented Jun 26, 2023

Add data from SFA - Open Finance

Documenation of the file format.


  • Checkout MergeTool branch
  • Open VS, VS Code, Rider, or your favourite IDE / Code Editor
  • Load the project (currently it is in C# .NET 7.0)
  • Add the required URLs to the Constants.cs file
  • Add a new enum item in the Source.cs file, named Sfa
  • Add a new method in the Reader.cs called LoadSfa, this should do all the heavy job of grabbing the information from the remote source.
  • Add the new field(s) to Bank.cs file
  • In the Seeder.cs file, implement the method MergeSfa to merge the new data with the existing ones. Prefer to filter the data by ISPB, then Document to check for existing data. Rely on the existing list, DO NOT ADD new bank to the list if it is not present with COMPE, ISPB, Document, and Name at least.
  • Call the new methods (LoadSfa and MergeSfa) in AcquireData method inside Program.cs file
  • On the Writer.cs file, edit the following methods, mapping the new field(s):
    • SaveCsv
    • SaveMarkdown
    • SaveSql
  • Test it 🧪 (just run locally and check the result directory)
  • Update schema files
  • Update DTO files
  • Commit and submit a PR 🎉
@github-actions github-actions bot added the .NET Pull requests that update .net code label Jun 26, 2023
@guibranco guibranco added enhancement A enhancement to the project dependencies Pull requests that update a dependency file documentation help wanted Feel free to take this issue for you and help me! good first issue A issue for someone self assign and help me =D labels Jun 28, 2023
@guibranco guibranco self-assigned this Jul 27, 2023
@guibranco guibranco added WIP and removed help wanted Feel free to take this issue for you and help me! good first issue A issue for someone self assign and help me =D labels Jul 27, 2023
@guibranco guibranco removed their assignment Aug 9, 2023
@guibranco guibranco added help wanted Feel free to take this issue for you and help me! good first issue A issue for someone self assign and help me =D new source and removed WIP labels Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation enhancement A enhancement to the project good first issue A issue for someone self assign and help me =D help wanted Feel free to take this issue for you and help me! .NET Pull requests that update .net code new source schema
Projects
None yet
Development

No branches or pull requests

1 participant