instanceof JsObject returns false functions

[gkdn]

instanceof JsObject returns false functions although instanceof Object returns true.
This because it is special cased to be translated as typeof == 'object' which doesn't return true for all cases.

[rluble]

should it be typeof == 'object' || typeof == 'function'?

[gkdn]

null and undefined should cast as well but instanceof those should fail.
I need to think more about it.

[rluble]

Isn't that the current behaviour for null/undefined?

On Thu, May 19, 2016 at 7:12 PM, Goktug Gokdogan notifications@github.com
wrote:

null and undefined should cast as well but instanceof those should fail.
I need to think more about it.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#9347 (comment)

[gkdn]

Might be, might be not. Needs to be verified since typeof null is 'object' while typeof undefined is 'undefined' so I would be surprised if the current implementation works correctly at the same time for both scenarios.

[rluble]

Yes. instanceof JsObject will return true for null and false for undefined.
Tricky, tricky, tricky.

On Thu, May 19, 2016 at 7:22 PM, Goktug Gokdogan notifications@github.com
wrote:

Might be, might be not. Needs to be verified since typeof null is 'object'
while typeof undefined is 'undefined' so I would be surprised if the
current implementation works correctly at the same time for both scenarios.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#9347 (comment)

[dankurka]

I am guessing this needs to be in 2.8 correct?

What is left to do here? Go through all cast scenarios in Casts.java and verify that the work as intended?

Who is going to do that work?

[gkdn]

We need update the test cases esp. around handling of null and primitives and functions.
The behavior should be like o != null && (typeof == objectt || typeof == function) - needs to be verified.

[rluble]

Code is up for review at https://gwt-review.googlesource.com/#/c/15173