Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buildmaster] Only rename downloaded files from builder after all downloads succeed #242

Open
waddlesplash opened this issue Feb 27, 2023 · 0 comments

Comments

@waddlesplash
Copy link
Member

Basically, move the rename out of this loop: https://github.com/haikuports/haikuporter/blob/master/HaikuPorter/Builders/RemoteBuilderSSH.py#L339

With the current model, if one file succeeds in downloading but the others do not, then the build will ultimately fail, but we will get "error some packages already exists" when retrying it, and those stray packages have to be manually deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant