Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'meson setup <builddir>' fails in recipes #249

Open
robxnano opened this issue Mar 25, 2023 · 1 comment · May be fixed by #250
Open

'meson setup <builddir>' fails in recipes #249

robxnano opened this issue Mar 25, 2023 · 1 comment · May be fixed by #250

Comments

@robxnano
Copy link

Recipe: https://github.com/haikuports/haikuports/blob/073bae46af6d69fc51db735aa457f1650f7377dc/media-libs/gst_plugins_good/gst_plugins_good-1.22.0.recipe
Log: https://build.haiku-os.org/buildmaster/master/x86_64/logviewer.html?buildruns/8335/builds/79082.log

Although the recipe used the recommended meson setup build command, rather than the deprecated meson build, the porter failed. The --wrap-mode=nodownload argument inserted here caused it to interpret setup as the name of a directory.

This needs to be fixed since the old syntax will be removed at some point in the future.
robxnano added a commit to robxnano/haikuporter that referenced this issue Mar 25, 2023
@robxnano
ShellScriptlets: Fix meson setup command
616f713 
Put --wrap-mode=nodownload at the end of the arguments list, to
avoid conflicting with the meson setup command. To allow recipes
to override, only use it when wrap-mode isn't in the arguments.
Fixes haikuports#249.
@korli
Copy link
Contributor

korli commented Mar 25, 2023

Pull request?

@korli korli linked a pull request Mar 25, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ShellScriptlets: Fix meson setup command robxnano/haikuporter
2 participants
@korli @robxnano