libpcre2-10.43 broken on gcc2

[Begasus]

Latest (at this moment) can't be build with gcc2, parse errors, I got a few fixed by lot's of others there (skill are not up to that).

[threedeyes]

After the update libpcre2 (9130150), Qt applications stop working under 32 bit Haiku. The error is invalid opcode exception. If you roll back libpcre2 version, the problem disappears.

[Begasus]

@threedeyes is this with the new version?
I've got latest x86 (10.43 and an older one 8.45) installed and 10.39 for gcc2, Qt-Assistant for instance still launches (on R1B4 still though).

[Begasus]

Should 10.43 be reverted to 10.42?
EDIT: or rolled back to 10.39 also for x86?

[augiedoggie]

I noticed this problem with KeePassXC last night on a fully updated R1/B4 installation.

[Begasus]

The 32bit install here is a fully synced R1B4 also here, launches fine here after installing on both 32bit and 64bit?

[Begasus]

Screenshot taken a minute ago:

[Begasus]

Updated screenshot with pcre2 packages installed:

[threedeyes]

The 32bit install here is a fully synced R1B4 also here, launches fine here after installing on both 32bit and 64bit?

The problem is reproduced on a fully updated R1B4 32bit. When running any applications using libpcre2 (including Qt applications) I get invalid opcode exception. Also apparently this package build failed for the same reason - https://build.haiku-os.org/buildmaster/master/x86_gcc2/logviewer.html?buildruns/5789/builds/82857.log

The error code says, the problem may be related to the processor type and appear on different same. Perhaps some optimizations were enabled when building the new version of libpcre2?

PS: I have AMD Rizen 7.

[augiedoggie]

I attempted to rebuild 10.43 in my VM and run the test suite with hp --test libpcre2_x86 and it continuously crashed with invalid opcodes. I'm on a Ryzen 5.

[Begasus]

Intel I5 here, will do testbuilds on 32bit with 10.39 and 10.43 to build kdoctools, if it fails on the newer one I'll disable the newer one untill this is fixed (or either of you can if you beat me to it).

[Begasus]

Changes done from 10.42 to 10.43 shown here: https://fossies.org/diffs/pcre2/10.42_vs_10.43/
Maybe something broke it for us, PR to bring back 10.42 is done, please check.

[threedeyes]

Changes done from 10.42 to 10.43 shown here: https://fossies.org/diffs/pcre2/10.42_vs_10.43/
Maybe something broke it for us, PR to bring back 10.42 is done, please check.

I see added autodetecting cpu code in 10.43

[Begasus]

I see added autodetecting cpu code in 10.43

Right, mentioned this earlier in IRC, probably explains different errors you see there that I don't see here.

[threedeyes]

I see added autodetecting cpu code in 10.43

Right, mentioned this earlier in IRC, probably explains different errors you see there that I don't see here.

I found the problem - AVX2 instructions. The 32bit version of Haiku does not support them. If you disable them, everything works fine.

https://github.com/PCRE2Project/pcre2/blob/master/src/sljit/sljitNativeX86_common.c#L511

[Begasus]

Eeps, just merged to revert to 10.42, will do some testruns to disable that (or you could take care of that), in the meantime checked a build for kdoctools 5.115.0 on 32bit, didn't error out here.

[Begasus]

@threedeyes maybe you could push kdoctools again for the buildmasters, libpcre2 10.42 is ready there, if that works well we can wait with bumping/fixing libpcre2 10.43 untill you are done for the KDE updates.

[threedeyes]

@threedeyes maybe you could push kdoctools again for the buildmasters, libpcre2 10.42 is ready there, if that works well we can wait with bumping/fixing libpcre2 10.43 untill you are done for the KDE updates.

I tested 10.43 with AVX2 disabled - kconfig and kdoctools compiled successfully.

[Begasus]

OK, then you could push the change to get 10.43 back in the depot :)

[threedeyes]

Then it probably makes sense to set the revision number to 2 to update those who got a non-functional version after the last update.

[Begasus]

Right, and to be sure the local packages get the correct version installed. +1