src/stick_table.c: null pointer dereference suspected by coverity

[chipitsine]

Tool Name and Version

coverity

Code Report

*** CID 1542870:  Null pointer dereferences  (REVERSE_INULL)
/src/stick_table.c: 709 in stktable_get_entry()
703                     len = key->key_len + 1 < table->key_size ? key->key_len : table->key_size - 1;
704             else
705                     len = table->key_size;
706     
707             shard = stktable_calc_shard_num(table, key->key, len);
708     
>>>     CID 1542870:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "key" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
709             if (!key)
710                     return NULL;
711     
712             HA_RWLOCK_RDLOCK(STK_TABLE_LOCK, &table->shards[shard].sh_lock);
713             ts = __stktable_lookup_key(table, key, shard);
714             if (ts)

Additional Information

No response

Output of haproxy -vv

no

[haproxyFred]

I have just pushed a fix for this. That said, as mentioned in the commit log, there are no callers of stktable_get_entry() which do not test the nullity of passed as parameter to this function (no crashes were possible), even if this is useless.