Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade package to be able to support Django 4.2 #230

Open
kwokster10 opened this issue Jan 22, 2024 · 3 comments
Open

Upgrade package to be able to support Django 4.2 #230

kwokster10 opened this issue Jan 22, 2024 · 3 comments

Comments

@kwokster10
Copy link

LTS support is ending for Django 3.2 in about 2 months. 4.2 is the next version that still has LTS. Ideally, the package should be upgraded to support 4.2 and 5.0.

The only error I'm seeing currently is this import error:
cannot import name 'smart_text' from 'django.utils.encoding' (/opt/pyre/lib/python3.8/site-packages/django/utils/encoding.py)

A suggested workaround is to do:

import django
from django.utils.encoding import smart_str
django.utils.encoding.smart_text = smart_str

Upgrading the package would be a more elegant solution than the above.

@kwokster10
Copy link
Author

It actually looks like @heavenshell fixed it in 2a1e432 but no new releases have been out since then. Is it possible to release a new version with latest changes on master?

@heavenshell
Copy link

heavenshell commented Feb 2, 2024

@kwokster10 Thank you for your comment and sorry for late response.
We are now bit busy, so please wait a while 🙏

P.S.
PRs are very welcome 😉

@kwokster10
Copy link
Author

@heavenshell thanks for the reply! No changes are need actually as you have fixed it already as I've noted in the second comment. The package only needs a release with the latest master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants