[BUG] You can enable a vGPU address without a profile

[noahgildersleeve]

Describe the bug

You can hit save in adding a vGPU profile without a profile selected
To Reproduce
Steps to reproduce the behavior:

1. Navigate to vGPU Devices
2. Click enable
3. Hit save without selecting a profile

Expected behavior

Save should be grayed out or you should get an error
Support bundle

supportbundle_314d015f-bac6-449f-a676-14fd3732e576_2024-05-08T23-05-09Z.zip

Environment

• Harvester ISO version: v1.3.0
• Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): DL360

Additional context
Add any other context about the problem here.

[ibrokethecloud]

we need to improve the validation logic in pcidevices and UI to prevent vgpu device to be enabled with an empty vGPU profile

vgpu definition from the support bundle

apiVersion: devices.harvesterhci.io/v1beta1
kind: VGPUDevice
metadata:
  annotations:
    sim.harvesterhci.io/creationTimestamp: "2024-05-08T17:26:59Z"
  creationTimestamp: "2024-05-08T17:26:59Z"
  generation: 1
  labels:
    harvesterhci.io/parentSRIOVGPUDevice: vgpu-2-000008000
    nodename: vgpu-2
  name: vgpu-2-000008006
  resourceVersion: "1427"
  uid: b1879c29-85a9-45c4-a50f-3f0125a1c7eb
spec:
  address: "0000:08:00.6"
  enabled: true
  nodeName: vgpu-2
  parentGPUDeviceAddress: "0000:08:00.0"
status: {}

[harvesterhci-io-github-bot]

added backport-needed/1.3.1 issue: #5776.

[torchiaf]

I pushed a PR to disable the Save button in the UI. I think there should be a validation step for the webhook as well.

[harvesterhci-io-github-bot]

Pre Ready-For-Testing Checklist

• If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
  The HEP PR is at:

• Where is the reproduce steps/test steps documented?
  The reproduce steps/test steps are at:

• Is there a workaround for the issue? If so, where is it documented?
  The workaround is at:

• Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
  The PR is at:

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

• If labeled: area/ui Has the UI issue filed or ready to be merged?
  The UI issue/PR is at:

• If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
  The documentation/KB PR is at:

• If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

  • The automation skeleton PR is at:
  • The automation test case PR is at:

• If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
  The compatibility issue is filed at:

[harvesterhci-io-github-bot]

Automation e2e test issue: harvester/tests#1260