Skip to content
This repository has been archived by the owner on Nov 2, 2018. It is now read-only.

Commit

Permalink
Small updates, nothing massive
Browse files Browse the repository at this point in the history
  • Loading branch information
hassankhan committed Feb 4, 2014
1 parent 5070eea commit 497c2c3
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 12 deletions.
10 changes: 1 addition & 9 deletions TODO.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
To-Do
====

## Router
- Also, should request and response be protected or public?

## Frontend
- Rewrite CSS to LESS
- Probably try and use Bootstrap
Expand All @@ -17,25 +14,20 @@ To-Do

## Application
- [Add support for environments ``[production|dev]``](https://github.com/hassankhan/Zepto/issues/4)
- Abstract-ify Whoops
- Move ``index.php`` to ``public`` folder
- Check for PHP version and use newer functions where available

## Router
- Add functionality to allow for other HTTP verbs
- Also, should request and response be protected or public?

## Templating Engine
- Add Twig extensions

## Plugins
- Add hooks to important parts of application by adding ``run_hooks()`` calls
- [``after_config_load`` isn't working at the minute, need to decouple it some](https://github.com/hassankhan/Zepto/issues/5)

## [Tests](https://github.com/hassankhan/Zepto/issues?milestone=1&state=open)
- Write MORE unit tests
- Add @dataProvider to ConsoleTest
- Maybe get some benchmarks up?
- [Add support for HHVM](https://github.com/hassankhan/Zepto/issues/3)

## ``zep``
- Make init wizard
Expand Down
6 changes: 3 additions & 3 deletions library/Zepto/Zepto.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public function __construct(array $settings = array())
$this->container = new Pimple();

// Get local reference to container
$container = $this->container;
$container = $this->container;

$container['request'] = $container->share(
function() {
Expand Down Expand Up @@ -319,8 +319,8 @@ protected function create_nav_links()

protected function generate_nav_html()
{
$container = $this->container;
$settings = $container['settings'];
$container = $this->container;
$settings = $container['settings'];
$content_loader = $container['content_loader'];

// Opening ``<ul>`` tag and adding class name
Expand Down
12 changes: 12 additions & 0 deletions tests/Zepto/ZeptoTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,18 @@ public function testConfigWithInvalidTemplatesDir()
Zepto::validate_config($config);
}

/**
* @covers Zepto\Zepto::validate_config()
* @expectedException InvalidArgumentException
*/
public function testConfigWithInvalidDefaultTemplate()
{
ob_start();
$config = Zepto::default_config();
$config['zepto']['default_template'] = 'no_such_file';
Zepto::validate_config($config);
}

/**
* @covers Zepto\Zepto::validate_config()
* @expectedException InvalidArgumentException
Expand Down

0 comments on commit 497c2c3

Please sign in to comment.