New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 5 #224
Comments
Thanks Connor, your tracking of this is really appreciated. I have been tracking Globalize since thats a really big blocker for us to go to Rails 5. I plan to start an official branch where we can start to work out the upgrade. |
👍 to my knowledge we're the largest open source Rails app and have somehow managed to not fall behind on Rails releases, so I figured it'd be useful to track the progress in-depth for everyone else to learn from :) Feel free to ping me if you run into any problems, I might be able to help - or at least know to look out for the problem in GitLab! |
Great - thanks for kicking this off, @connorshea. @scott it may be worth setting up a GitHub milestone for this. Until then, I'll track the related PRs here: PR #230 - Update 'rails' and dependencies to 4.2.7 Note: some PRs may need rebasing for conflicts in Once the PRs are merged in, I'll create a |
As you can see, I set up a milestone. I will start to tick off these PRs as time allows. Most hopefully most will go in fairly easily. |
@scott @olliebennett with Devise you can update to 4.0 for now, which has Rails 5 support and just a deprecation warning for the omniauth change. |
You'll also need to upgrade the Gemfile to use at least Ruby 2.2.2 (right now it's 2.2.1), I'd recommend the latest patch release in the 2.2 series. |
Thanks @connorshea |
Also worth looking at rails5-spec-converter gem, because this change may cause a lot of deprecation warnings otherwise. |
Also with regards to Devise, here's how we fixed the deprecation warnings: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5331 |
After a bit of sleuthing it also looks like you'll need to upgrade devise_invitable for Devise 4.1/4.2 support, though 4.0 is fine on the current version: https://github.com/scambra/devise_invitable/blob/master/CHANGELOG |
I wanted to suggest upgrading Helpy to Rails 5, or at least get a conversation started about it.
I've been keeping track of our progress getting to the upgrade at GitLab, figured you may find all my notes useful :)
Some notes based on a quick look through your Gemfile:
Lots of information on upgrading those gems, etc. is available in the issue I linked above. This project looks awesome, kudos!
Best,
Connor
The text was updated successfully, but these errors were encountered: