Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for installing keys (i.e. apt-key add) #33

Open
catkhuu opened this issue Apr 3, 2018 · 2 comments · May be fixed by #41
Open

Add support for installing keys (i.e. apt-key add) #33

catkhuu opened this issue Apr 3, 2018 · 2 comments · May be fixed by #41

Comments

@catkhuu
Copy link

catkhuu commented Apr 3, 2018 •
edited

I want to install the nginx-nr-agent with apt. This works fine with the buildpack, but prior to installing the package, I need to gain access to the repository by downloading and installing the key with apt-key add nginx_signing.key. This throws an error, because apt-key add can only be executed with root access.

I would love to see support for installing keys with this buildpack, and had envisioned something similar to the way we install repositories, where the link following :key: is the link to download the key.

:key:https://nginx.org/keys/nginx_signing.key   #download and install key
:repo:deb deb http://nginx.org/packages/ubuntu/ xenial nginx   #download and install repo
nginx-nr-agent   #install package
@catkhuu catkhuu changed the title Add support for installing keys (e.g. apt-key add <my-key>) Add support for installing keys (apt-key add) Apr 3, 2018
@catkhuu catkhuu changed the title Add support for installing keys (apt-key add) Add support for installing keys (i.e. apt-key add) Apr 3, 2018
@amiel
Copy link

amiel commented Oct 25, 2018

Has anyone looked in to adding this? If not, I'll give it a shot today.

This was referenced Oct 25, 2018
Open
Merged
@amiel
Copy link

amiel commented Oct 26, 2018 •
edited

Ok, check out #41. You can try it out by specifying the branch like this:

heroku buildpacks:add --index=1 https://github.com/amiel/heroku-buildpack-apt#feature/support-adding-keys

# and you might need to remove the other buildpack if you still have it
heroku buildpacks:remove https://github.com/heroku/heroku-buildpack-apt

@edmorley edmorley mentioned this issue Jan 25, 2021
Closed
@jrochkind jrochkind mentioned this issue Mar 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for specifying a custom key to be added to the trusted keys amiel/heroku-buildpack-apt
2 participants
@amiel @catkhuu