Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Opting Out of Immutable Flags for Yarn 2 #834

Open
jpulec opened this issue Aug 25, 2020 · 3 comments
Open

Allow Opting Out of Immutable Flags for Yarn 2 #834

jpulec opened this issue Aug 25, 2020 · 3 comments

Comments

@jpulec
Copy link

jpulec commented Aug 25, 2020

In some cases, a user may not want the --immutable-cache or --immutable flag to be passed. One example I have is when you have a repo with some workspace packages that you're not passing to Heroku by adding them to your .slugignore. In this case, the lock files would change, which means calling install --immutable will fail.

Additionally, when yarn install --immutable does fail for this reason, there's no indication, and the build just appears to hang.

@jpulec jpulec changed the title Allow Opting Out of Immutable Flags Allow Opting Out of Immutable Flags for Yarn 2 Aug 25, 2020
@danielleadams
Copy link
Contributor

#836 solves half of this, but we still need a way to call Yarn 2 without --immutable. @jpulec how should the buildpack detect that yarn.lock should be mutable?

@jpulec
Copy link
Author

jpulec commented Sep 26, 2020

I'm wondering if it makes sense to allow disabling this via an environment variable. Something that is off by default, but could be set to allow lockfile discrepencies, i.e. YARN_IMMUTABLE=false.

@joeyfigaro
Copy link

Any updates here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants