Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling (restrict) nodename convention #83

Closed
hnimminh opened this issue Jan 2, 2023 · 2 comments
Closed

Better handling (restrict) nodename convention #83

hnimminh opened this issue Jan 2, 2023 · 2 comments
Assignees
@hnimminh
Labels
enhancement New feature or request

Comments

@hnimminh
Copy link
Owner

hnimminh commented Jan 2, 2023 •
edited

take a look on #81 for more detail
@hnimminh hnimminh added the enhancement New feature or request label Jan 2, 2023
@hnimminh hnimminh self-assigned this Jan 2, 2023
@hnimminh hnimminh changed the title Better handling (retrict) nodename convention Better handling (restrict) nodename convention Dec 21, 2023
@poldy42
Copy link

poldy42 commented Jun 4, 2024

Good morning,
is there a change to the node name restrictions here? This is coming to my attention because our hosts are named according to the "xx-yy-zzz-0001" pattern and a new name assignment would be difficult to handle... Is there any reason to restrict the names that way ?
Cheers - Michael

@hnimminh
Copy link
Owner Author

hnimminh commented Jun 5, 2024

@poldy42 thanks for reminder, I will review and make a fix in this weekend.

@hnimminh hnimminh pinned this issue Jun 5, 2024
hnimminh added a commit that referenced this issue Jun 10, 2024
@hnimminh
Add hyphen - into _NAME_ patten #83
b7670d2
@hnimminh hnimminh unpinned this issue Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hnimminh hnimminh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hnimminh @poldy42