Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convolve with size=0 should be identity #50

Open
jbednar opened this issue Mar 10, 2017 · 0 comments
Open

Convolve with size=0 should be identity #50

jbednar opened this issue Mar 10, 2017 · 0 comments
Milestone

Comments

@jbednar
Copy link
Contributor

jbednar commented Mar 10, 2017

Right now, if the Convolve operator is put on the output_fn of a pattern, as the size of the kernel pattern tends towards zero, the resulting image becomes more and more like the original image. However, when it reaches zero, the result has division errors, instead of becoming identity. It might be necessary to make a special case, perhaps by checking if self.kernel in imagen.sheet_tf.Convolve is all zeros?

@jbednar jbednar added this to the Next Release milestone Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant