Use device class enum where possible and supply possible states for those sensors #4394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see those are strings we defined now. Can we maybe do a small refactor so the values aren't duplicated? |
edit: figured it out, created a map and used that instead |
jpelgrom
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4393
the device class is only set for when the new device class was added.
i decided to keep the options for all users as I can personally see value in it for user on older versions.
i reviewed all our sensors and these ones have a defined list in our code.
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#n/a
Any other notes