Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohomekit to 0.2.67 (fixes #51391) #51418

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

Jc2k
Copy link
Member

@Jc2k Jc2k commented Jun 3, 2021

Proposed change

aiohomekit wasn't handling C# in mdns metadata. Normally spec compliant devices use c#. This is a regression for users with Lennox iComfort S30 devices that weren't using static DHCP leases. This version bump normalizes the c# field so we can handle these devices again.

This is a one line change in aiohomekit (+ a test) and the change has been confirmed to work by the user reporting the issue.

Changelog: Jc2k/aiohomekit@0.2.66...0.2.67

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @bdraco, mind taking a look at this pull request as its been labeled with an integration (homekit_controller) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad it turned out not to need the new zeroconf.

@bdraco
Copy link
Member

bdraco commented Jun 3, 2021

Tested with a myq bridge, working as expected

@bdraco bdraco merged commit 836ce44 into home-assistant:dev Jun 3, 2021
@bdraco bdraco linked an issue Jun 3, 2021 that may be closed by this pull request
balloob pushed a commit that referenced this pull request Jun 3, 2021
@balloob balloob mentioned this pull request Jun 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2021
@Jc2k Jc2k deleted the homekit_controller_51391 branch January 28, 2022 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.