Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello from mainline #27

Closed
fasterthanlime opened this issue Aug 15, 2014 · 6 comments
Closed

Hello from mainline #27

fasterthanlime opened this issue Aug 15, 2014 · 6 comments

Comments

@fasterthanlime
Copy link

I'm just now discovering all your work - already cherry-picked e9100a3 to fix ooc-lang#774 but I'm sure there's a lot of good stuff that we can merge back to mainline if you want to.

Can we discuss this here? Or on the mailing list? Let me know.

Cheers,

  • Amos
@horasal
Copy link
Owner

horasal commented Aug 16, 2014

Thank you for opening this issue. I'm glad my commit is accpetted.
Here are several commits and I think they will help the development in mainline.

Waiting for your reply.

Zhai

fa0190a
fixes
ooc-lang#759

horasal/nagaqueen@d417002
adds scientific notation support

30b9006
adds support for "main: func(args: String[])"

b7891f3
913ad35
tries to fix incorrect matching of overloaded function ( #1 ) . This patch is urly and I think it can be solved smarter.

@fasterthanlime
Copy link
Author

Thanks for the pointers, getting started right now :)

Just merged fa0190a.

@fasterthanlime
Copy link
Author

Merged horasal/nagaqueen@d417002

@fasterthanlime
Copy link
Author

TODO:

@fasterthanlime
Copy link
Author

For #1, I came up with a much shorter fix, look into ooc-lang#789 if you're curious. Everything is merged now.

In the future, can we agree on a protocol when you have issues relevant to mainline? I don't want to hinder the effort on your side - it's cool if you want to take rock in different directions, let's just try and continue sharing issue reports / fixes when we can.

Perhaps some of your more radical ideas could be adopted in mainline too, who knows :)

@horasal
Copy link
Owner

horasal commented Aug 16, 2014

Sure, It's great to be able to help the development of rock.
I will report issue to mainline and open a pull request if any fix is ready.

horasal pushed a commit that referenced this issue Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants