Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intended behavior of Variables window? #9

Open
chrstphrchvz opened this issue Mar 23, 2015 · 1 comment
Open

Intended behavior of Variables window? #9

chrstphrchvz opened this issue Mar 23, 2015 · 1 comment

Comments

@chrstphrchvz
Copy link
Collaborator

There's a few things I notice about the Variables window:

  • The list variables (i.e. which labels) is only updated automatically when loading a source file in a new/empty session or when opening another session, not when recompiling, opening another source file, or when opening a new session.
  • Every label or #define is selected, rather than just those corresponding to certain pseudo-opcodes (e.g. ds, rmb, fcc), so it's a long list by default for any programs using e.g. Reg9s12.h; although I can see how it's necessary to include labels for other cases--given the nature of labels, it might be hard to tell exactly what is data (variable or array), instructions, or in cases such as self-modifying code, both.

I'm not sure how much of this is intentional; I have yet to look closely at how this is implemented in auto_select_variables(). So at a minimum this might be an undocumented feature.

Since one might edit the Variables window by hand, it's fine to leave it as it is where it doesn't reselect, but it may be useful to add a button that allows the user to invoke variable reselection.

@hotwolf
Copy link
Owner

hotwolf commented Apr 8, 2015

The automatic generation of a variable list is just an attempt to display something useful by default. It is intended to be replaced by a user defined variable list. Maybe it would even be better to leave the variable list empty by default.
As for the types of symbols to display, HSW12 symbols only have a name and a value. HSW12 does provide any further information to distinguish labels from register definitions. So it's not easy to remove useless symbols from the auto-generated variable list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants