Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review fileWriting #26

Open
mantayjon opened this issue Apr 21, 2023 · 3 comments
Open

review fileWriting #26

mantayjon opened this issue Apr 21, 2023 · 3 comments
Assignees
@chrisWolter @nathalieclaire
Labels
review wanted Extra attention is needed

Comments

@mantayjon
Copy link
Contributor

No description provided.

@chrisWolter chrisWolter self-assigned this Apr 21, 2023
@chrisWolter
Copy link
Contributor

Tests are running.
No Problems found.

@bkleinen bkleinen added the review wanted Extra attention is needed label Apr 22, 2023
@nathalieclaire nathalieclaire self-assigned this Apr 24, 2023
nathalieclaire added a commit that referenced this issue Apr 24, 2023
@nathalieclaire
see issue #26
f80c92d
@nathalieclaire
Copy link
Contributor

I fixed the typo in line 7. Everything else looks very good: see changes

leunami420 added a commit that referenced this issue Apr 24, 2023
@leunami420
fixed the test issue #26
4225720
@leunami420
Copy link
Contributor

I tried to change the expected outcome to read "This is a" but the test still passed as OK. So I changed the assertion to self.assertEqual(file.read(), "this is a test") instead of self.assertIn("this is a test", file.read()) Now the test fails, if the expected outcome is edited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisWolter chrisWolter

@nathalieclaire nathalieclaire

Labels
review wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bkleinen @chrisWolter @nathalieclaire @mantayjon @leunami420