New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows send WebSocket message to any fd in current server, even the worker process does not hold the fd #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangzhhui
reviewed
Aug 17, 2019
huangzhhui
reviewed
Aug 17, 2019
huangzhhui
reviewed
Aug 18, 2019
huangzhhui
reviewed
Aug 18, 2019
huangzhhui
reviewed
Aug 18, 2019
huangzhhui
reviewed
Aug 18, 2019
@huangzhhui 都改过了 |
huangzhhui
reviewed
Aug 19, 2019
src/websocket-server/src/Server.php
Outdated
{ | ||
$this->server = $server; | ||
return $this->container->get(ServerFactory::class)->getServer()->getServer(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里应该改成获取 Swoole\Server
huangzhhui
changed the title
Fixed fd does not found when server::push.
Allows send WebSocket message to any fd in current server, even the worker process does not hold the fd
Aug 19, 2019
huangzhhui
approved these changes
Aug 19, 2019
文档上咋没有 |
这里并没有改变 WebSocket 本身的使用方式,我们只是加强了它的容错性,文档上也可以写一下我们会这么做 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #403