Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

异步队列任务支持按配置阶梯重试 #599

Merged
merged 5 commits into from Sep 24, 2019

Conversation

airzhe
Copy link

@airzhe airzhe commented Sep 20, 2019

业务上队列需要采用阶梯方式重试,配置如下:

#按次配置重试时间
'retry_seconds' => [15, 15, 30, 180, 600, 1200, 1800]

Copy link
Member

@limingxinleo limingxinleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个修改实在是太小众了。。你为啥不重写一个 RedisDriver,然后重写这个方法呢?

@limingxinleo
Copy link
Member

总感觉这里不需要修改框架的代码

@limingxinleo
Copy link
Member

image
配置中,是允许替换 driver 的

@airzhe
Copy link
Author

airzhe commented Sep 20, 2019

这个修改实在是太小众了。。你为啥不重写一个 RedisDriver,然后重写这个方法呢?

这个需求并不小众,我们目前就是重写了 RedisDriver 里的方法,只是希望框架能原生支持

@huangzhhui
Copy link
Member

@airzhe 如果已经实现,也可以向官方仓库提 PR 的

@airzhe
Copy link
Author

airzhe commented Sep 20, 2019

@airzhe 如果已经实现,也可以向官方仓库提 PR 的

这个就是已经实现,我们在用的啊

@limingxinleo limingxinleo reopened this Sep 20, 2019
@limingxinleo limingxinleo added this to the v1.1.x milestone Sep 20, 2019
@huangzhhui
Copy link
Member

哦,我看错了,我以为这个是 issue,我晚点再看看

Copy link
Member

@huangzhhui huangzhhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog 还需要修改下

@limingxinleo limingxinleo merged commit 452aaf0 into hyperf:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants