Add modifiedBy to MaintenanceEvent to improve data validation

hyperic · Nov 21, 2009 · 4440ed8 · 4440ed8
1 parent de4e5d6
commit 4440ed8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/hqu/hqapi1/app/MaintenanceController.groovy b/hqu/hqapi1/app/MaintenanceController.groovy
@@ -9,7 +9,8 @@ class MaintenanceController extends ApiController {
             MaintenanceEvent(state:     m.state,
                              groupId:   m.groupId,
                              startTime: m.startTime,
-                             endTime:   m.endTime) {
+                             endTime:   m.endTime,
+                             modifiedBy: m.modifiedBy) {
                 State(m.state)
             }
         }

diff --git a/src/org/hyperic/hq/hqapi1/test/MaintenanceTestBase.java b/src/org/hyperic/hq/hqapi1/test/MaintenanceTestBase.java
@@ -165,6 +165,8 @@ Group createGroup(List<Resource> resources) throws Exception {
     void valididateMaintenanceEvent(MaintenanceEvent e, Group g, long start, long end) {
         assertEquals(e.getGroupId(), g.getId().intValue());
         assertEquals(e.getStartTime(), start);
-        assertEquals(e.getEndTime(), end);        
+        assertEquals(e.getEndTime(), end);
+        assertNotNull(e.getModifiedBy());
+        assertTrue(e.getModifiedBy().trim().length() > 0);
     }
 }
diff --git a/xsd/HQApi1.xsd b/xsd/HQApi1.xsd
@@ -863,7 +863,8 @@
         </xs:sequence>
         <xs:attribute name="endTime"        type="xs:long"    use="required"/>
         <xs:attribute name="startTime"      type="xs:long"    use="required"/>
-        <xs:attribute name="groupId"        type="xs:int"     use="required"/>     
+        <xs:attribute name="groupId"        type="xs:int"     use="required"/>
+        <xs:attribute name="modifiedBy"     type="xs:string"  use="optional" />
     </xs:complexType>
 
     <!-- Maintenance response objects -->