You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
date-fns should be in dependencies, otherwise apps won't start.
[BUG] Bug Reproduce Steps
Install react-date-range without installing date-fns.
Starting the app fails with an errors like: Module not found: Error: Can't resolve 'date-fns/max' in '[...]\node_modules\react-date-range\dist\components\Calendar'
[BUG] Expected behaviour
As this package uses date-fns (in Calendar for example), it should be a dependency and not a peerDependency, which will make npm installing this package also install the needed date-fns package.
Subject of the issue
date-fns
should be independencies
, otherwise apps won't start.[BUG] Bug Reproduce Steps
react-date-range
without installingdate-fns
.Module not found: Error: Can't resolve 'date-fns/max' in '[...]\node_modules\react-date-range\dist\components\Calendar'
[BUG] Expected behaviour
As this package uses
date-fns
(in Calendar for example), it should be a dependency and not a peerDependency, which will makenpm install
ing this package also install the neededdate-fns
package.Environment
Package Version: 1.4.0
React version: 17.0.2
Node version: 16.16.0
The text was updated successfully, but these errors were encountered: