Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi plz implement tablet ring #5960

Open
Ciel-MC opened this issue May 9, 2024 · 4 comments
Open

Hi plz implement tablet ring #5960

Ciel-MC opened this issue May 9, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Ciel-MC
Copy link

Ciel-MC commented May 9, 2024

Description

Idk what to say, it's the spinnie thing for changing like brush size or zoom, yeah

@Ciel-MC Ciel-MC added the enhancement New feature or request label May 9, 2024
@MightyPlaza
Copy link
Contributor

should this not be a plugin?

@vaxerski
Copy link
Member

vaxerski commented May 9, 2024

lol, no. It's something I left out from the tablet rewrite as a todo because I don't know what it is or how it works

void CTabletV2Protocol::strip(SP<CTabletPad> pad, uint32_t strip, double position, bool finger, uint32_t timeMs) {
LOGM(ERR, "FIXME: STUB: CTabletV2Protocol::strip not implemented");
}
void CTabletV2Protocol::ring(SP<CTabletPad> pad, uint32_t ring, double position, bool finger, uint32_t timeMs) {
LOGM(ERR, "FIXME: STUB: CTabletV2Protocol::ring not implemented");
}

@MightyPlaza
Copy link
Contributor

oh lol, I thought it was like a UI menu that appears when you long press the screen, not an actual physical button

@Ciel-MC
Copy link
Author

Ciel-MC commented May 10, 2024

lol, no. It's something I left out from the tablet rewrite as a todo because I don't know what it is or how it works

void CTabletV2Protocol::strip(SP<CTabletPad> pad, uint32_t strip, double position, bool finger, uint32_t timeMs) {
LOGM(ERR, "FIXME: STUB: CTabletV2Protocol::strip not implemented");
}
void CTabletV2Protocol::ring(SP<CTabletPad> pad, uint32_t ring, double position, bool finger, uint32_t timeMs) {
LOGM(ERR, "FIXME: STUB: CTabletV2Protocol::ring not implemented");
}

Idk what you're expected to forward to the apps, but essentially it's an analogue input (akin to the scroll wheel), with the ring looping to 0 after 360 and the strip not doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants