hyprpm: Cannot udpate headers

[LokiNaBoki]

Hyprland Version

System/Version info

Hyprland, built from branch  at commit cba1ade848feac44b2eda677503900639581c3f4  (props: bump version to 0.40.0).
Date: Sat May 4 15:42:32 2024
Tag: v0.40.0, commits: 4606

flags: (if any)


System Information:
System name: Linux
Node name: Asgard
Release: 6.8.9-arch1-2
Version: #1 SMP PREEMPT_DYNAMIC Tue, 07 May 2024 21:35:54 +0000


GPU information: 
09:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Ellesmere [Radeon RX 470/480/570/570X/580/580X/590] [1002:67df] (rev cf) (prog-if 00 [VGA controller])


os-release: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo


plugins:

Bug or Regression?

Bug

Description

After updating Hyprland to 40.0, whenever I try to update the headers with hyprpm it exits with fatal: error processing shallow info: 4

Doing the git clone on my own works

~ $ cd /tmp/hyprpm 
/tmp/hyprpm $ mkdir hyprland-loki  
/tmp/hyprpm $ git clone --recursive https://github.com/hyprwm/hyprland hyprland-loki --shallow-since="$(date --date='Sat May 4 15:42:32 2024 - 1 weeks' '+%a %b %d %H:%M%S %Y')"

Cloning into 'hyprland-loki'...
remote: Enumerating objects: 30133, done.
remote: Counting objects: 100% (5885/5885), done.
remote: Compressing objects: 100% (767/767), done.
remote: Total 30133 (delta 5428), reused 5308 (delta 5117), pack-reused 24248
Receiving objects: 100% (30133/30133), 65.32 MiB | 9.36 MiB/s, done.
Resolving deltas: 100% (23434/23434), done.
Submodule 'subprojects/hyprland-protocols' (https://github.com/hyprwm/hyprland-protocols) registered for path 'subprojects/hyprland-protocols'
Submodule 'subprojects/tracy' (https://github.com/wolfpld/tracy) registered for path 'subprojects/tracy'
Submodule 'subprojects/udis86' (https://github.com/canihavesomecoffee/udis86) registered for path 'subprojects/udis86'
Submodule 'subprojects/wlroots-hyprland' (https://github.com/hyprwm/wlroots-hyprland) registered for path 'subprojects/wlroots-hyprland'
Cloning into '/tmp/hyprpm/hyprland-loki/subprojects/hyprland-protocols'...
remote: Enumerating objects: 69, done.        
remote: Counting objects: 100% (27/27), done.        
remote: Compressing objects: 100% (17/17), done.        
remote: Total 69 (delta 18), reused 10 (delta 10), pack-reused 42        
Receiving objects: 100% (69/69), 20.54 KiB | 1.14 MiB/s, done.
Resolving deltas: 100% (31/31), done.
Cloning into '/tmp/hyprpm/hyprland-loki/subprojects/tracy'...
remote: Enumerating objects: 39334, done.        
remote: Counting objects: 100% (12363/12363), done.        
remote: Compressing objects: 100% (527/527), done.        
remote: Total 39334 (delta 11982), reused 11914 (delta 11831), pack-reused 26971        
Receiving objects: 100% (39334/39334), 27.31 MiB | 9.02 MiB/s, done.
Resolving deltas: 100% (28335/28335), done.
Cloning into '/tmp/hyprpm/hyprland-loki/subprojects/udis86'...
remote: Enumerating objects: 2433, done.        
remote: Counting objects: 100% (65/65), done.        
remote: Compressing objects: 100% (45/45), done.        
remote: Total 2433 (delta 34), reused 48 (delta 20), pack-reused 2368        
Receiving objects: 100% (2433/2433), 1.34 MiB | 7.56 MiB/s, done.
Resolving deltas: 100% (1495/1495), done.
Cloning into '/tmp/hyprpm/hyprland-loki/subprojects/wlroots-hyprland'...
remote: Enumerating objects: 50082, done.        
remote: Counting objects: 100% (31/31), done.        
remote: Compressing objects: 100% (22/22), done.        
remote: Total 50082 (delta 10), reused 18 (delta 4), pack-reused 50051        
Receiving objects: 100% (50082/50082), 10.93 MiB | 5.66 MiB/s, done.
Resolving deltas: 100% (39336/39336), done.
Submodule path 'subprojects/hyprland-protocols': checked out 'e06482e0e611130cd1929f75e8c1cf679e57d161'
Submodule path 'subprojects/tracy': checked out '37aff70dfa50cf6307b3fee6074d627dc2929143'
Submodule path 'subprojects/udis86': checked out '5336633af70f3917760a6d441ff02d93477b0c86'
Submodule path 'subprojects/wlroots-hyprland': checked out '5c1d51c5a2793480f5b6c4341ad0797052aec2ea'

Also shouldn't the check if shallow clone succeeded

Hyprland/hyprpm/src/core/PluginManager.cpp

Line 454 in 38911d6

if (!std::filesystem::exists(WORKINGDIR)) {

check for the existence of the .git directory, like the check non shallow clone?

Hyprland/hyprpm/src/core/PluginManager.cpp

Line 459 in 38911d6

if (!std::filesystem::exists(WORKINGDIR + "/.git")) {

The WORKINGDIR is created with createSafeDirectory so even if the shallow clone fails the directory will exist.

Hyprland/hyprpm/src/core/PluginManager.cpp

Line 438 in 38911d6

if (!createSafeDirectory(WORKINGDIR)) {

How to reproduce

Update the headers with hyprpm update

Crash reports, logs, images, videos

$ hyprpm -v update
[v] version returned: Hyprland, built from branch  at commit cba1ade848feac44b2eda677503900639581c3f4  (props: bump version to 0.40.0).
Date: Sat May 4 15:42:32 2024
Tag: v0.40.0, commits: 4606

flags: (if any)


[v] parsed commit cba1ade848feac44b2eda677503900639581c3f4 at branch  on Sat May 4 15:42:32 2024, commits 4606

! Cloning https://github.com/hyprwm/hyprland, this might take a moment.                      
[v] will shallow since: sob kwi 27 15:42:32 2024                                             

 ╍━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━  0 / 5  Cloning the hyprland repository  
✖ Could not clone the hyprland repository. shell returned:
Cloning into 'hyprland-loki'...
fatal: error processing shallow info: 4

[luravoid]

i have the same issue

[vaxerski]

ah, likely cuz git can't parse the date because your system language is not english. I see the date isn't english.

[LokiNaBoki]

Yep, you are right, executing LC_TIME="en_US.UTF-8" hyprpm update works

[vaxerski]

should be fixed now then