Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyprpm: build plugins with user specified build flags #5997

Open
ThatOneCalculator opened this issue May 10, 2024 · 8 comments
Open

hyprpm: build plugins with user specified build flags #5997

ThatOneCalculator opened this issue May 10, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@ThatOneCalculator
Copy link
Contributor

Description

Right now when installing/updating plugins that are built from source with hyprpm, they build with only one core, however, most systems would be able to update a lot faster by taking advantage of all cores when building.

@ThatOneCalculator ThatOneCalculator added the enhancement New feature or request label May 10, 2024
@vaxerski
Copy link
Member

most plugins are very few files, and using all cores can hang the system up drastically though

@ThatOneCalculator
Copy link
Contributor Author

Maybe half of system cores then?

@thejch
Copy link
Contributor

thejch commented May 10, 2024

if this were to be changed, it should respect user system environment setting (e.g. MAKEFLAGS or CMAKE_BUILD_PARALLEL_LEVEL) instead of hardcoding a number of threads IMO. hogging all cores or even half the cores is undesirable sometimes, and for other people they might want to use all cores and half would be too few for these people

@ThatOneCalculator ThatOneCalculator changed the title hyprpm: build plugins with -j$(nproc) hyprpm: build plugins with user specified build flags May 10, 2024
@MahouShoujoMivutilde
Copy link

I agree with the comment above, for how small plugins typically are it takes way too long (even comparable to the whole hyprland build in chroot by aurutils, on my system).

using all cores can hang the system up drastically though

Which is completely nuts that that can still happen on a modern system.

For anyone who cares about responsiveness under a heavy load I suggest linux-zen (linux-rt is better, obviously, but has issues) or ananicy-cpp with rules to set a high nice values for any not realtime-critical cpu-hogging application.

@vaxerski
Copy link
Member

I use zen and even then when cpu usage is close to 100% the system goes to shit :P

@ThatOneCalculator
Copy link
Contributor Author

Strangely enough, I only noticed that one compiling c++ (xanmod). Compiling rust, c, zig, etc and of course definitely makes my system slow down a bit but not crawl to a halt :P

@fufexan
Copy link
Member

fufexan commented May 11, 2024

Plugins can be built with cmake + ninja if you want to use all cores.

@ThatOneCalculator
Copy link
Contributor Author

The point of this issue is that there should be some way to configure it for hyprpm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants