Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if undo-redo extension is registered when undoable option is true #40

Open
metincansiper opened this issue Jun 28, 2017 · 0 comments

Comments

@metincansiper
Copy link
Collaborator

I think that this extension considers whether undoRedo extension is registered when undoable option is true at some code segments (https://github.com/iVis-at-Bilkent/cytoscape.js-expand-collapse/blob/unstable/src/undoRedoUtilities.js#L2). But it does not consider it consistently, so the extension crashes when you initilize it in undoable mode (it is undoable by default) where the undoRedo extension is not registered and then try to expand/collapse nodes.

@ugurdogrusoz ugurdogrusoz changed the title Bug for checking whether undoRedo extension is registered when undoable option is true Check if undo-redo extension is registered when undoable option is true Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant