Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next_occurrences can return incorrect times when from time is near DST boundary. #525

Open
flivni opened this issue Mar 31, 2022 · 0 comments

Comments

@flivni
Copy link

flivni commented Mar 31, 2022

It seems like there is a bug where if you pass a from time to schedule.next_occurrences that is close to the DST boundary, you can get future occurrences that occur on the wrong time.

E.g. A recurring appointment that occurs every Sunday at 01:15 am London time. If you call schedule.next_occurrences(from_time) where from_time is just prior to March 27, 2022 01:00 am, all occurrences shift an hour forward to 2:15 am local time.

I created a PR with a failing test that demonstrates the issue.
#524

Any help would be appreciated!

@flivni flivni changed the title next_occurrences can be wrong when passing from time near DST boundary. next_occurrences can return incorrect times from time is near DST boundary. Mar 31, 2022
@flivni flivni changed the title next_occurrences can return incorrect times from time is near DST boundary. next_occurrences can return incorrect times when from time is near DST boundary. Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant