Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring: replace pkg/xgenny.NewEmbedWalker by io/fs.Sub in template generators #3393

Open
tbruyelle opened this issue Jan 9, 2023 · 0 comments
Open

refactoring: replace pkg/xgenny.NewEmbedWalker by io/fs.Sub in template generators #3393

tbruyelle opened this issue Jan 9, 2023 · 0 comments
Assignees
@julienrbrt
Labels
type:feature To implement new feature.
Milestone
v29

Comments

@tbruyelle
Copy link
Contributor

pkg/xgenny.NewEmbedWalker is used to remove the files prefix from the filesystem passed as a embed.FS. But since go 1.16 we can use io/fs.Sub for this purpose, which is more standard.

As an exemple, this is done in PR #3381 for the app generator.

Once all generators are updated, pkg/xgenny.NewEmbedWalker and related types can probably be removed.
@tbruyelle tbruyelle added the type:feature To implement new feature. label Jan 9, 2023
@tbruyelle tbruyelle mentioned this issue Jan 9, 2023
Merged
@aljo242 aljo242 added this to the v0.27.0 milestone Jan 9, 2023
@julienrbrt julienrbrt self-assigned this Sep 29, 2023
@Pantani Pantani modified the milestones: v0.27.0, v0.28, v0.29 Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienrbrt julienrbrt

Labels
type:feature To implement new feature.
Projects
Ignite CLI Masterboard
Status: Doing
Milestone
v29
Development

No branches or pull requests
4 participants
@tbruyelle @Pantani @julienrbrt @aljo242