Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functions before 1.0 #2575

Open
szhorvat opened this issue Apr 17, 2024 · 6 comments
Open

Remove deprecated functions before 1.0 #2575

szhorvat opened this issue Apr 17, 2024 · 6 comments
Milestone

Comments

@szhorvat
Copy link
Member

Old deprecated functions should be removed before the 1.0 release.

Add functions that shouldn't be removed, or whose removal needs discussion, to the following list (with a short reasoning):

  • ... ?
@szhorvat szhorvat added this to the 1.0 milestone Apr 17, 2024
@szhorvat
Copy link
Member Author

List of deprecated functions:

igraph_centrality.h
193:IGRAPH_DEPRECATED IGRAPH_EXPORT igraph_error_t igraph_hub_score(const igraph_t *graph, igraph_vector_t *vector,
197:IGRAPH_DEPRECATED IGRAPH_EXPORT igraph_error_t igraph_authority_score(const igraph_t *graph, igraph_vector_t *vector,

igraph_paths.h
335:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_random_edge_walk(const igraph_t *graph,

igraph_conversion.h
62:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_get_sparsemat(const igraph_t *graph, igraph_sparsemat_t *res);
65:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_get_stochastic_sparsemat(const igraph_t *graph,

igraph_nongraph.h
108:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_zeroin(

igraph_foreign.h
53:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_read_graph_dimacs(igraph_t *graph, FILE *instream,
89:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_write_graph_dimacs(const igraph_t *graph, FILE *outstream,

igraph_bipartite.h
92:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_incidence(
97:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_get_incidence(
102:IGRAPH_EXPORT IGRAPH_DEPRECATED  igraph_error_t igraph_bipartite_game(

igraph_interface.h
146:IGRAPH_DEPRECATED IGRAPH_EXPORT igraph_error_t igraph_delete_vertices_idx(

igraph_structural.h
44:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_are_connected(const igraph_t *graph, igraph_integer_t v1, igraph_integer_t v2, igraph_bool_t *res);
166:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_laplacian(

igraph_topology.h
171:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_isomorphic_function_vf2(
220:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_subisomorphic_function_vf2(
315:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_isomorphic_34(

igraph_iterators.h
91:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_vs_seq(igraph_vs_t *vs, igraph_integer_t from, igraph_integer_t to);
92:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_vs_t igraph_vss_seq(igraph_integer_t from, igraph_integer_t to);
293:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_es_seq(igraph_es_t *es, igraph_integer_t from, igraph_integer_t to);
294:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_es_t igraph_ess_seq(igraph_integer_t from, igraph_integer_t to);

igraph_vector_pmt.h
37:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t FUNCTION(igraph_vector, init_seq)(TYPE(igraph_vector)*v, BASE from, BASE to);
40:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t FUNCTION(igraph_vector, copy)(
71:IGRAPH_EXPORT IGRAPH_DEPRECATED BASE FUNCTION(igraph_vector, e)(const TYPE(igraph_vector)* v, igraph_integer_t pos);
72:IGRAPH_EXPORT IGRAPH_DEPRECATED BASE* FUNCTION(igraph_vector, e_ptr)(const TYPE(igraph_vector)* v, igraph_integer_t pos);
297:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t FUNCTION(igraph_vector, move_interval2)(

igraph_hrg.h
126:IGRAPH_DEPRECATED IGRAPH_EXPORT igraph_error_t igraph_hrg_dendrogram(

igraph_games.h
222:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_erdos_renyi_game(

igraph_matrix_pmt.h
42:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t FUNCTION(igraph_matrix, copy)(
50:IGRAPH_EXPORT IGRAPH_DEPRECATED BASE FUNCTION(igraph_matrix, e)(
52:IGRAPH_EXPORT IGRAPH_DEPRECATED BASE* FUNCTION(igraph_matrix, e_ptr)(

igraph_config.h.in
38:#define IGRAPH_DEPRECATED_ENUMVAL @IGRAPH_DEPRECATED_ENUMVAL@

igraph_operators.h
93:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_subgraph_edges(

igraph_sparsemat.h
301:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_sparsemat_copy(
303:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_sparsemat_diag(
306:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_sparsemat_eye(

igraph_constructors.h
58:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_lattice(igraph_t *graph, const igraph_vector_int_t *dimvector, igraph_integer_t nei,
64:IGRAPH_EXPORT IGRAPH_DEPRECATED igraph_error_t igraph_tree(igraph_t *graph, igraph_integer_t n, igraph_integer_t children,

@ntamas
Copy link
Member

ntamas commented Apr 19, 2024

All of these seem okay to me, no reason not to remove them.

@szhorvat
Copy link
Member Author

@krlmlr @Antonov548 Let us know if the removal of any of these would cause an issue for R/igraph

@krlmlr
Copy link
Contributor

krlmlr commented Apr 29, 2024

@Antonov548: can you please do a quick grep exercise in src/interface.c and src/interface_extra.c ?

@szhorvat
Copy link
Member Author

@krlmlr The compiler should give warnings when you use a deprecated function (unless this was disabled—I don't remember). There was one deprecation I can recall since the last R release.

Please ignore the following, which will only become deprecated in 1.0:

igraph_interface.h
146:IGRAPH_DEPRECATED IGRAPH_EXPORT igraph_error_t igraph_delete_vertices_idx(

@Antonov548
Copy link

As long as I remember it was disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants