Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename igraph_community_eb_get_merges() #2578

Open
szhorvat opened this issue Apr 17, 2024 · 2 comments
Open

Rename igraph_community_eb_get_merges() #2578

szhorvat opened this issue Apr 17, 2024 · 2 comments

Comments

@szhorvat
Copy link
Member

igraph_community_eb_get_merges() should have a name that does not associate it with igraph_community_edge_betweenness(). This function is useful in general scenarios where a sequence of edges is removed.

@szhorvat szhorvat added this to the 1.0 milestone Apr 17, 2024
@ntamas
Copy link
Member

ntamas commented Apr 19, 2024

Not sure about this; in theory, the function could be useful, but it needs to be generalized in several ways in order to make it really flexible, and I'm not sure it should be a priority for 1.0. In particular, the function should support

  • processing edge sequences starting from the entire graph, removing edges one by one according to the sequence, or
  • processing edge sequences starting from the empty graph, adding edges one by onw

We should also make sure that the function handles partial edge sequences well, i.e. cases when not all edges of the graph are enumerated in the edge sequence. We would also need checks for duplicate edge IDs and so on. The current function does not cater for these cases I think because it's designed only to handle the output of the edge betweenness algorithm where you know that edges are removed one by one and that all of them are removed in the end.

@szhorvat
Copy link
Member Author

Alright, then let's remove this from the milestone. If needed, we can add a more flexible alternative with a new name in the future, and deprecate this one.

@szhorvat szhorvat removed this from the 1.0 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants