Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppHash implements TryFrom<Vec<u8>> rather than From<Vec<u8>> #1243

Open
hdevalence opened this issue Dec 6, 2022 · 0 comments
Open

AppHash implements TryFrom<Vec<u8>> rather than From<Vec<u8>> #1243

hdevalence opened this issue Dec 6, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@hdevalence
Copy link
Collaborator

What went wrong?

The opaque AppHash type implements TryFrom<Vec<u8>> rather than From<Vec<u8>>, even though the conversion is actually infallible.

Definition of "done"

Change the TryFrom<Vec<u8>> impl to From<Vec<u8>> to reflect infallibility (the apphash can be arbitrary data).
@hdevalence hdevalence added the bug Something isn't working label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hdevalence