Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abci::response::SetOption and abci::request::SetOption are missing Default impls #1244

Open
hdevalence opened this issue Dec 6, 2022 · 0 comments
Open

abci::response::SetOption and abci::request::SetOption are missing Default impls #1244

hdevalence opened this issue Dec 6, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@hdevalence
Copy link
Collaborator

What went wrong?

The abci::response::SetOption (and abci::request::SetOption) types are missing Default impls, which makes it annoying to fill in default implementations of these requests.

Definition of "done"

Add Default impls.
@hdevalence hdevalence added the bug Something isn't working label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hdevalence