Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for syntax highlighting #31

Open
ad-si opened this issue Jun 26, 2018 · 3 comments
Open

Support for syntax highlighting #31

ad-si opened this issue Jun 26, 2018 · 3 comments

Comments

@ad-si
Copy link

ad-si commented Jun 26, 2018

It would be cool if there was a config flag to switch on syntax highlighting

@martijnbastiaan
Copy link
Collaborator

I'd like to keep this package focused on its core: providing a "pretty" replacement for Aeson's default printer. I feel packages like Pygments (+hpygments) will do a much better job than we could reasonably do. Sorry @ad-si!

@ad-si
Copy link
Author

ad-si commented Nov 14, 2021

I think a JSON syntax highlighter is so simple (specifying one color for the key and another one for the value - e.g. this file) that it would not unreasonable extend the scope of the package, but that's of course your call. At any rate, thanks for your work on this package!

@martijnbastiaan
Copy link
Collaborator

Hmm, I had overlooked that there's already a PR open and that the original maintainer/author was in favor of it. In that case, I'd like to honor it. Maybe we can get the PR in a mergeable state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants