Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In selected state, illegible title due to low contrast to background #527

Open
mediter opened this issue Mar 22, 2019 · 6 comments
Open

Comments

@mediter
Copy link

mediter commented Mar 22, 2019

Screen Shot 2019-03-21 at 11 36 54 PM

@insidegui
Copy link
Owner

@mediter There is no need to comment that the issue is still occurring. We'll close this issue when it gets fixes.

@el-greco-de-github
Copy link

@insidegui I followed the trail here for adhering to system theming, apologies for commenting on an old issue with an unrelated topic, but I felt it appropriate to ask before opening a new issue.

Out of pure curiosity, why the persistent dark mode over adhering to the system?

@insidegui
Copy link
Owner

It’s a media consumption app, it was a design choice.

@el-greco-de-github
Copy link

el-greco-de-github commented May 19, 2020

I'll play around with it and see how it looks. Might be able to get it looking nice in both themes. If not, oh well. I have a thing for the light/dark theming (don't lean either way, but am a believer that most apps should adhere to the system...it looks weird when a light app is alongside a bunch of dark ones, or vise versa). EDIT: Ok I do prefer dark mode, but it's a reward for working late, non?

EDIT: Also the WWDC app on iOS now supports both themes, might be cool to match it.

@insidegui
Copy link
Owner

Thank you for the experimentation, but we don't have any intention of supporting both themes.

Repository owner locked as off-topic and limited conversation to collaborators May 19, 2020
Repository owner unlocked this conversation May 29, 2020
@insidegui
Copy link
Owner

I couldn't reproduce this anymore as of #600. Anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants