Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Failure Recovery #529

Open
mediter opened this issue Mar 24, 2019 · 5 comments
Open

Download Failure Recovery #529

mediter opened this issue Mar 24, 2019 · 5 comments
Assignees
Labels

Comments

@mediter
Copy link

mediter commented Mar 24, 2019

Currently:

  1. Sometimes download failures are silent, meaning that they do not invoke alerts.
  2. All the failed downloads are removed from the download manager automatically.

This is in contrast to how apps like Safari are handling these situations: the failed download would remain in the download queue with a resume button.

Judging by the fact that videos being downloaded prior to app relaunch would resume their previous process, the system does not remove the temp file associated with each download task, at least not immediately.

So it is not too far fetched to suggest that recently failed download could be resumed from the point of failure. Also, would u consider changing failed download notice from alert window to notifications, which would be less interruptive.

@allenhumphreys
Copy link
Collaborator

@mediter Are the failures you're referring to happening when the app is not running? Could you give a specific way to reproduce the failures?

Regarding using local notifications: That's an excellent suggestion, we could even do download completion notifications.

As an FYI, Safari manages persistence above and beyond what NSURLSession provides out of the box to keep track of certain things.

@mediter
Copy link
Author

mediter commented Mar 25, 2019

I am in Beijing, China. Local ISP China Unicom 50Mbps broadband

What did you mean by "when the app is not running"?

To reproduce the failure, maybe you can try the following:
try to download at least 20 videos all at once.

@allenhumphreys
Copy link
Collaborator

allenhumphreys commented Mar 25, 2019

What did you mean by "when the app is not running"?

The downloads continue to run when you quit the app since they are background downloads.

@lizhaojie001
Copy link

I met some server error about downloadURL sometimes

@mediter
Copy link
Author

mediter commented Mar 25, 2019

What did you mean by "when the app is not running"?

The downloads continue to run when you quit the app since they are background downloads.

It is when the app is running. I didn't know it has this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants