Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-delete watched videos #567

Open
Blackjacx opened this issue Jun 10, 2019 · 2 comments
Open

Auto-delete watched videos #567

Blackjacx opened this issue Jun 10, 2019 · 2 comments
Labels

Comments

@Blackjacx
Copy link

It would be cool to provide an option in the settings to auto-delete watched session videos so they do not clutter up disk space.

Specs

  • Version of macOS: 10.14.5
  • Version of the app: 6.1.2
@insidegui
Copy link
Owner

Removing the "Good first issue" tag since as it turns out, this is not as simple as it sounds 😅 (Developing in #570).

@bcmn
Copy link
Collaborator

bcmn commented Jul 13, 2019

Closed #570 as I'm not likely to revisit it immediately. Just to capture...

• Needs toggle in Preferences
• Must respect existing "watched" definition, used for filters, etc.
• Should probably sweep for watched videos on first enabling
• Avoid deleting newly-watched videos until player torn down (it shouldn't be disastrous, but seems unwise) -- but we don't have a stop state for videos, which makes this a little tricky
• Should probably delete immediately if "mark as watched" used

There's some interesting obstacles in the code to get around to achieve these.

Alternatively, maybe we run a sweep semi-regularly (on launch?) whenever the feature is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants