Fix popup window detection in message viewer

Fixes #4518
Alinto · Sep 13, 2018 · ec4d93a · ec4d93a
1 parent ff7e8cb
commit ec4d93a
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 8 deletions.
diff --git a/NEWS b/NEWS
@@ -14,6 +14,7 @@ Bug fixes
  - [web] fixed display of notification email in calendar properties
  - [web] fixed display of multi-days events when some weekdays are disabled
  - [web] fixed synchronisation of calendar categories
+ - [web] fixed popup window detection in message viewer (#4518)
 
 4.0.2 (2018-08-24)
 ------------------

diff --git a/UI/WebServerResources/js/Mailer/MailboxController.js b/UI/WebServerResources/js/Mailer/MailboxController.js
@@ -184,15 +184,14 @@
               targetEvent: $event,
               clickOutsideToClose: false,
               escapeToClose: false,
-              scope: $scope,
-              preserveScope: true,
               templateUrl: 'UIxMailEditor',
               controller: 'MessageEditorController',
               controllerAs: 'editor',
               onComplete: function (scope, element) {
                 return onCompleteDeferred.resolve(element);
               },
               locals: {
+                stateParent: $scope,
                 stateAccount: vm.account,
                 stateMessage: message,
                 onCompletePromise: function () {

diff --git a/UI/WebServerResources/js/Mailer/Mailer.popup.js b/UI/WebServerResources/js/Mailer/Mailer.popup.js
@@ -246,15 +246,14 @@
         disableParentScroll: false,
         clickOutsideToClose: false,
         escapeToClose: false,
-        scope: $scope,
-        preserveScope: true,
         templateUrl: 'UIxMailEditor',
         controller: 'MessageEditorController',
         controllerAs: 'editor',
         onComplete: function (scope, element) {
           return onCompleteDeferred.resolve(element);
         },
         locals: {
+          stateParent: $scope,
           stateAccount: stateAccount,
           stateMessage: stateMessage,
           onCompletePromise: function () {

diff --git a/UI/WebServerResources/js/Mailer/MessageController.js b/UI/WebServerResources/js/Mailer/MessageController.js
@@ -285,15 +285,14 @@
               targetEvent: $event,
               clickOutsideToClose: false,
               escapeToClose: false,
-              scope: $scope,
-              preserveScope: true,
               templateUrl: 'UIxMailEditor',
               controller: 'MessageEditorController',
               controllerAs: 'editor',
               onComplete: function (scope, element) {
                 return onCompleteDeferred.resolve(element);
               },
               locals: {
+                stateParent: $scope,
                 stateAccount: vm.account,
                 stateMessage: message,
                 onCompletePromise: function () {

diff --git a/UI/WebServerResources/js/Mailer/MessageEditorController.js b/UI/WebServerResources/js/Mailer/MessageEditorController.js
@@ -6,11 +6,12 @@
   /**
    * @ngInject
    */
-  MessageEditorController.$inject = ['$scope', '$window', '$stateParams', '$mdConstant', '$mdUtil', '$mdDialog', '$mdToast', 'FileUploader', 'stateAccount', 'stateMessage', 'onCompletePromise', 'encodeUriFilter', '$timeout', 'sgFocus', 'Dialog', 'AddressBook', 'Card', 'Preferences'];
-  function MessageEditorController($scope, $window, $stateParams, $mdConstant, $mdUtil, $mdDialog, $mdToast, FileUploader, stateAccount, stateMessage, onCompletePromise, encodeUriFilter, $timeout, focus, Dialog, AddressBook, Card, Preferences) {
+  MessageEditorController.$inject = ['$scope', '$window', '$stateParams', '$mdConstant', '$mdUtil', '$mdDialog', '$mdToast', 'FileUploader', 'stateParent', 'stateAccount', 'stateMessage', 'onCompletePromise', 'encodeUriFilter', '$timeout', 'sgFocus', 'Dialog', 'AddressBook', 'Card', 'Preferences'];
+  function MessageEditorController($scope, $window, $stateParams, $mdConstant, $mdUtil, $mdDialog, $mdToast, FileUploader, stateParent, stateAccount, stateMessage, onCompletePromise, encodeUriFilter, $timeout, focus, Dialog, AddressBook, Card, Preferences) {
     var vm = this;
 
     this.$onInit = function() {
+      $scope.isPopup = stateParent.isPopup;
       vm.addRecipient = addRecipient;
       vm.autocomplete = {to: {}, cc: {}, bcc: {}};
       vm.autosave = null;