Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: swipe to close modal does not use custom animation #20577

Closed
liamdebeasi opened this issue Feb 21, 2020 · 2 comments
Closed

bug: swipe to close modal does not use custom animation #20577

liamdebeasi opened this issue Feb 21, 2020 · 2 comments
Labels
package: core @ionic/core package type: bug a confirmed bug report
Milestone

Comments

@liamdebeasi
Copy link
Member

liamdebeasi commented Feb 21, 2020

Bug Report

Ionic version:

[x] 5.x

Current behavior:

Modal with custom leave animation is not used when swipeToClose = true. The standard card-style animation is used.

Expected behavior:

I would expect that users can provide a custom animation to the swipe to close modal.

Steps to reproduce:

  1. Open https://codepen.io/ionic/pen/ExapZBZ.
  2. Set modalElement.mode = 'ios'.
  3. Set modalElement.swipeToClose = true.
  4. Open modal and attempt to swipe closed.

Code for possible fix: https://github.com/ionic-team/ionic/blob/master/core/src/utils/overlays.ts#L129-L132

@ionitron-bot ionitron-bot bot added the triage label Feb 21, 2020
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report and removed triage labels Feb 21, 2020
@liamdebeasi liamdebeasi added this to the 5.0.2 milestone Feb 21, 2020
@liamdebeasi
Copy link
Member Author

Resolved by #20585

@ionitron-bot
Copy link

ionitron-bot bot commented Mar 25, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

1 participant