fix(react): create a new overlay each time component is presented, fixes

#19841, #19823 (#19842)
ionic-team · Nov 5, 2019 · 9fad416 · 9fad416
1 parent 17fe23a
commit 9fad416
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/packages/react/src/components/createControllerComponent.tsx b/packages/react/src/components/createControllerComponent.tsx
@@ -54,18 +54,15 @@ export const createControllerComponent = <OptionsType extends object, OverlayTyp
 
     async present(prevProps?: Props) {
       const { isOpen, onDidDismiss, ...cProps } = this.props;
-      let overlay = this.overlay;
-      if (!overlay) {
-        overlay = this.overlay = await controller.create({
-          ...cProps as any
-        });
-      }
-      attachProps(overlay, {
+      this.overlay = await controller.create({
+        ...cProps as any
+      });
+      attachProps(this.overlay, {
         [dismissEventName]: onDidDismiss
       }, prevProps);
       // Check isOpen again since the value could of changed during the async call to controller.create
       if (this.props.isOpen === true) {
-        await overlay.present();
+        await this.overlay.present();
       }
     }