Skip to content

Commit

Permalink
fix(radio-group): get radios before caching value to avoid infinite l…
Browse files Browse the repository at this point in the history
…oop (#19448)

fixes #19277
  • Loading branch information
liamdebeasi committed Sep 25, 2019
1 parent 446cf78 commit cf223e4
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion core/src/components/radio-group/radio-group.tsx
Expand Up @@ -83,8 +83,14 @@ export class RadioGroup implements ComponentInterface {
}

private async updateRadios() {
const { value } = this;
/**
* Make sure we get all radios first
* so values are up to date prior
* to caching the radio group value
*/
const radios = await this.getRadios();
const { value } = this;

let hasChecked = false;

// Walk the DOM in reverse order, since the last selected one wins!
Expand Down

0 comments on commit cf223e4

Please sign in to comment.