Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Type to navigation parameters get() #19195

Merged
merged 1 commit into from Nov 7, 2019

Conversation

Himujjal
Copy link

@Himujjal Himujjal commented Aug 27, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

No Generic Type to navParams() while it is returned right now.
Issue Number: N/A

What is the new behavior?

  • There is a generic type to navParams()

Does this introduce a breaking change?

  • Yes
  • No

Other information

A Generic Type to the navigation parameter on line 41 can help a little bit in the documentation process.
@ionitron-bot ionitron-bot bot added the package: angular @ionic/angular package label Aug 27, 2019
@brandyscarney brandyscarney merged commit 504051d into ionic-team:master Nov 7, 2019
@brandyscarney
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants