Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(title): add large iOS toolbar title #19268

Merged
merged 73 commits into from Sep 4, 2019
Merged

feat(title): add large iOS toolbar title #19268

merged 73 commits into from Sep 4, 2019

Conversation

liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Sep 4, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #16885

What is the new behavior?

Adds the iOS 11 header design.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added package: angular @ionic/angular package package: core @ionic/core package labels Sep 4, 2019
@liamdebeasi liamdebeasi merged commit 923312e into master Sep 4, 2019
@liamdebeasi liamdebeasi deleted the feat-ios-toolbar branch September 4, 2019 15:45
brandyscarney added a commit that referenced this pull request Sep 16, 2019
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
brandyscarney added a commit that referenced this pull request Oct 2, 2019
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@mutatedplague
Copy link

So how do I implement the large toolbar looking through the merge i cant seem to find how to enable it

@liamdebeasi
Copy link
Member Author

@t8
Copy link

t8 commented Oct 21, 2019

I'm having an issue utilizing this new feature with header colors.

<ion-header>
  <ion-toolbar id="collapsedToolbar" color="primary">
    <ion-buttons slot="start" collapse="true">
      <ion-back-button
              [text]="'Back'"
              [icon]="'arrow-back'">
      </ion-back-button>
    </ion-buttons>
    <ion-title>
      add a task ✏️
    </ion-title>
  </ion-toolbar>
</ion-header>

<ion-content>
  <ion-header collapse="condense">
    <ion-toolbar color="primary">
      <ion-buttons slot="start" collapse="true">
        <ion-back-button
                [text]="''"
                [icon]="'arrow-back'">
        </ion-back-button>
      </ion-buttons>
      <ion-title size="large">
        add a task ✏️
      </ion-title>
    </ion-toolbar>
  </ion-header>
// Rest of irrelevant code here
<ion-content>

This displays a toolbar with a correctly colored header in the content, but the collapsed header does not have this color: https://imgur.com/a/zAdA1rn
Note: I'm using the new Ionic Dark Mode feature as well. I noticed that the error was the same even without dark mode enabled.

@mutatedplague
Copy link

I had to add this inside the class .ios body.dark to get the header color to come out right in dark mode

.header-ios {
    background-color: #0d0d0d;
}

@t8
Copy link

t8 commented Oct 21, 2019

@mutatedplague That solution appears to work for dark mode, but if I want things to be able to transition automatically from dark to light mode, would that still work?

Also thank you so much for the quick reply!

@mutatedplague
Copy link

It works on my end as long as you have it inside .ios body.dark

@liamdebeasi
Copy link
Member Author

This is a known issue, and we are currently working on a fix for this 👍

@t8
Copy link

t8 commented Oct 21, 2019

@liamdebeasi Thank you!

Is there any current way to add a back button to this type of header or is that in the works as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants