New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(title): add large iOS toolbar title #19268
Conversation
…into feat-ios-toolbar merge
…rgin, account for large title in navigation transitions
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
So how do I implement the large toolbar looking through the merge i cant seem to find how to enable it |
I'm having an issue utilizing this new feature with header colors.
This displays a toolbar with a correctly colored header in the content, but the collapsed header does not have this color: https://imgur.com/a/zAdA1rn |
I had to add this inside the class .ios body.dark to get the header color to come out right in dark mode
|
@mutatedplague That solution appears to work for dark mode, but if I want things to be able to transition automatically from dark to light mode, would that still work? Also thank you so much for the quick reply! |
It works on my end as long as you have it inside .ios body.dark |
This is a known issue, and we are currently working on a fix for this 👍 |
@liamdebeasi Thank you! Is there any current way to add a back button to this type of header or is that in the works as well? |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #16885
What is the new behavior?
Adds the iOS 11 header design.
Does this introduce a breaking change?
Other information