feat(modal): update iOS design, add swipe gesture #19428
Conversation
liamdebeasi
force-pushed
the
new-modal-swipe
branch
from
eb2c44d
to
0c95251
Compare
There was a problem hiding this comment.
Overall looking much better! A few notes:
- I recall us talking about moving the animation fixes to a separate PR. Can we still do that? This PR has about 1,500 lines of changes, so debugging is pretty difficult right now.
- Gesture based animations in CSS Animations mode (Safari and iOS) still flickers (swipe to go back, swipe to open menu, etc)
- Cannot open multiple menus one after the other (iOS mode CSS Animations and Web Animations)
- Modal presentation animation flickers
- Alert enter animation on iOS is not correct (it just appears instead of fading/scaling in)
Also, I'd recommend pulling in the latest master as it has fixes for a few other bugs I am seeing. Let me know when you do that and I can do some more testing.
|
I am removing code from this PR that is not directly related to the new modal functionality. Animation interface updates PR: #19964 Hide Caret changes branch: https://github.com/ionic-team/ionic/tree/hide-caret |
liamdebeasi
changed the title
|
|
||
| // onstart(0.5) 0.5 -> 1 onFinish(1) | ||
| // onstart(0.5) 0.5 -> 0 onFinish(0) | ||
| // onstart(false) START 0->1 END onFInish(true) |
There was a problem hiding this comment.
| // onstart(false) START 0->1 END onFInish(true) | |
| // onstart(false) START 0->1 END onFinish(true) |
There was a problem hiding this comment.
@manucorporat do you still want these comments in here, or can I remove then?
| // onstart(false) START 0->1 END onFInish(true) | ||
| // onstart(true) END 1->0 START onFinish(false) | ||
|
|
||
| // onstart(false) START 0->1 END onFInish(true) |
There was a problem hiding this comment.
| // onstart(false) START 0->1 END onFInish(true) | |
| // onstart(false) START 0->1 END onFinish(true) |
Dev build:
5.0.0-dev.201912021616.e60f230needs review: https://github.com/ionic-team/ionic/pull/19428/files#diff-24fcc947660e79d1b2f094ec1b7dc3f5. not sure I like the way I implemented this. Basically I need to destroy the entering and leaving animations, otherwise the two conflict when running the leaving animation. --Liam
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #18660
What is the new behavior?
Does this introduce a breaking change?
Other information