Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular ivy #19515

Merged
merged 29 commits into from Dec 18, 2019
Merged

Angular ivy #19515

merged 29 commits into from Dec 18, 2019

Conversation

mhartington
Copy link
Member

No description provided.

@ionitron-bot ionitron-bot bot added package: angular @ionic/angular package package: core @ionic/core package labels Oct 1, 2019
@mhartington mhartington force-pushed the angular-ivy branch 2 times, most recently from eb906f1 to d52c215 Compare November 1, 2019 21:34
@mhartington
Copy link
Member Author

Needs ionic-team/stencil#2033 to be merged/resolved

@brandyscarney
Copy link
Member

ionic-team/stencil#2033 has been merged, need a new pre-release for testing

@mhartington mhartington mentioned this pull request Dec 16, 2019
Closed
13 tasks
@dennisameling dennisameling mentioned this pull request Dec 16, 2019
Closed
vially
vially suggested changes Dec 16, 2019
View reviewed changes
.scripts/common.js Outdated Show resolved Hide resolved
brandyscarney
brandyscarney requested changes Dec 17, 2019
View reviewed changes
.scripts/common.js Outdated Show resolved Hide resolved
.scripts/common.js Outdated Show resolved Hide resolved
.scripts/common.js Outdated Show resolved Hide resolved
@brandyscarney
Copy link
Member

I updated the release script to fix some of my comments. The only outstanding comment is related to the order of updating the core dependencies and running npm link. This may cause issues, I want to say that's why they were separate.

Overall testing of the dev build seems to be going well, so that's my only concern!

@brandyscarney
Copy link
Member

:shipit:

@mhartington mhartington merged commit 2344d0b into master Dec 18, 2019
@brandyscarney brandyscarney deleted the angular-ivy branch March 24, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vially vially vially requested changes

@SchnWalter SchnWalter SchnWalter left review comments

@dylanvdmerwe dylanvdmerwe dylanvdmerwe left review comments

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees
No one assigned
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mhartington @brandyscarney @vially @SchnWalter @dylanvdmerwe @adamdbradley