Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(searchbar): add --box-shadow variable to style searchbar input #19838

Merged
merged 2 commits into from Nov 8, 2019
Merged

feat(searchbar): add --box-shadow variable to style searchbar input #19838

merged 2 commits into from Nov 8, 2019

Conversation

antoinecfmws
Copy link
Contributor

We would like to style the box-shadow property in searchbar and give the parent the ability to control it.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

(Sorry running on a windows box and unable to run "sass")

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): SCSS File Update to expose a css variable / property for searchbar

What is the current behavior?

Issue Number: N/A
The behaviour modification is simply to expose a css variable that is currently not exposed and set by default for md styles on component searchbar.

What is the new behavior?

  • This PR exposes --box-shadow so that we can have control over that property
  • Users using md style for searchbar will be able to set the box-shadow on the input with class "searchbar-input"

Does this introduce a breaking change?

  • Yes
  • No

N/A

Other information

N/A

We would like to style the box-shadow property in searchbar and give the parent the ability to control it.
@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Nov 5, 2019
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I moved the box-shadow to the main file so that it will apply for both modes.

@liamdebeasi I had to remove contain: strict so the ios input could receive a box shadow. Let me know if you foresee issues with this.

@brandyscarney brandyscarney changed the title Updates searchbar.md.scss to expose box-shadow feat(searchbar): add --box-shadow variable to style searchbar input Nov 7, 2019
@liamdebeasi liamdebeasi merged commit 1ab7066 into ionic-team:master Nov 8, 2019
@liamdebeasi
Copy link
Contributor

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants