Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): support collapsible header with multiple toolbars #19909

Merged
merged 7 commits into from Nov 18, 2019

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 14, 2019

Dev build 5.0.0-dev.201911141743.24e780d

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  1. IO and scroll listener did not work properly with multiple toolbars
  2. iOS transition did not account for multiple toolbars when determining animation translate

What is the new behavior?

  • Added a forEach to the header to toggle all toolbars, not just the first toolbar
  • Adjusted iOS transition to account for the real title/back button top offsets when setting positioning of the fake title/back buttons.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Nov 14, 2019
@liamdebeasi liamdebeasi marked this pull request as ready for review November 14, 2019 17:55
@liamdebeasi liamdebeasi merged commit fc4bb2d into master Nov 18, 2019
@liamdebeasi liamdebeasi deleted the collapsible-multi branch November 18, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants