Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(title): large title nav transition adds correct safe area value #20029

Merged
merged 1 commit into from Dec 2, 2019

Conversation

liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Dec 2, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #20028

What is the new behavior?

  • This change caused the bug. The top safe area value is already included in the result of getBoundingClientRect, so we were essentially adding the top safe area value twice, which resulted in the cloned back button/title being in the wrong location.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Dec 2, 2019
@liamdebeasi liamdebeasi merged commit 300d543 into master Dec 2, 2019
@liamdebeasi liamdebeasi deleted the large-title-safe-area branch December 2, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant