Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Ionic React - Don't render overlay children if not shown #20225

Closed
elylucas opened this issue Jan 17, 2020 · 1 comment
Closed

bug: Ionic React - Don't render overlay children if not shown #20225

elylucas opened this issue Jan 17, 2020 · 1 comment
Labels

Comments

@elylucas
Copy link
Contributor

Bug Report

Ionic version:
Ionic React 4.11.8

[x] 4.x

Current behavior:
An overlay component (modal/action sheet/popover, etc.) should not render its children if not currently being shown. Currently, children are rendered even though they are not currently displayed if isOpen is false.

Expected behavior:
Children of overlays should properly mount/unmount each time an overlay is presented and dismissed.

Steps to reproduce:

Related code:

insert short code snippets here

Other information:

Ionic info:

insert the output from ionic info here
@ionitron-bot
Copy link

ionitron-bot bot commented Feb 16, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant