Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(label): remove subpixel font-size to prevent visual glitches #20415

Merged
merged 2 commits into from Feb 10, 2020

Conversation

liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Feb 7, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #20407

Subpixel font-sizes + CSS animations seem to cause some odd visual glitches in Safari, so I've opted to remove the subpixel font size here. There should be no noticeable difference in most browsers as the difference in size is only 0.4px.

This bug has no impact on browsers that support Web Animations.

What is the new behavior?

  • Changed 13.6px --> 14px

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Feb 7, 2020
@liamdebeasi liamdebeasi marked this pull request as ready for review February 7, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant